fix(ChatGptController): Chinese encoding issue#310
Merged
hirokiterashima merged 2 commits intoWISE-Community:developfrom Dec 23, 2025
Merged
fix(ChatGptController): Chinese encoding issue#310hirokiterashima merged 2 commits intoWISE-Community:developfrom
hirokiterashima merged 2 commits intoWISE-Community:developfrom
Conversation
Member
hirokiterashima
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR. Fix works as described. Can you clean up ChatGptcontroller.java (I added suggestions inline), and remove wise_api_local_changes.patch file?
src/main/java/org/wise/portal/presentation/web/controllers/ChatGptcontroller.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wise/portal/presentation/web/controllers/ChatGptcontroller.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review! I’ve removed the debug print, cleaned up the unused imports, and deleted the local patch file as suggested. The PR has been updated. |
Member
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an encoding issue in the AI component where Chinese responses
returned from the OpenAI API were displayed as "??????????" in the WISE dialog.
Root Cause
The OpenAI HTTP response was being read using the default character set, which resulted
in the response being interpreted as ISO-8859-1. Since Chinese characters cannot be
represented in ISO-8859-1, the UI displayed garbled text ("???????").
Fix Implemented
ChatGptController.javato explicitly read the HTTP response stream usingISO-8859-1when parsing the OpenAI response.correctly handled by the downstream components in WISE.
Why ISO-8859-1?
ISO-8859-1.ISO-8859-1prevents character loss during the initial read operation becauseit maps bytes directly (1:1), allowing the actual UTF-8 content inside the JSON to be
preserved for correct later parsing.
Impact
Testing
displayed correctly in the dialog.